Page MenuHomeFreeBSD

Account for the new "laundry" memory in ksysguard in preparation for 11.1
ClosedPublic

Authored by rezny on Jul 11 2017, 5:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 6:46 AM
Unknown Object (File)
Thu, Apr 25, 2:31 AM
Unknown Object (File)
Fri, Apr 19, 12:15 PM
Unknown Object (File)
Mar 11 2024, 12:05 PM
Unknown Object (File)
Mar 4 2024, 8:10 PM
Unknown Object (File)
Feb 17 2024, 10:34 PM
Unknown Object (File)
Feb 13 2024, 8:28 PM
Unknown Object (File)
Jan 15 2024, 1:55 PM

Details

Summary

Recent src changes have introduced another memory accounting variable that ksysguard needs to be aware of. As fas as I understand it, "laundry" is essentially a subset of "inactive" that is now reported separately. So, handle it in ksysguardd by adding "laundry" where "inactive" is reported to ksysguard.

Test Plan

used on 11-stable for several weeks

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcberner added a subscriber: tcberner.

Looks good to me. Could you upstream it into the current ksysguard ?

This revision is now accepted and ready to land.Jul 11 2017, 7:10 AM

On second thought --

  • don't you need to check whether the sysctl exists? -- or has it trickled down to all the versions?
  • don't forget to bump portrevision
This revision now requires changes to proceed.Jul 11 2017, 7:15 AM
rezny edited edge metadata.

bump PORTREVISION

On second thought --

  • don't you need to check whether the sysctl exists? -- or has it trickled down to all the versions?

No need to check; if it doesn't exist (it'll be in 11.1, not sure if 10 gets it) sysctlbyname will return -1, set errno to ENOENT, and leave the output variable unchanged (remains zero).

  • don't forget to bump portrevision

of course :)

Thanks. In that case, go ahead :)

This revision is now accepted and ready to land.Jul 12 2017, 7:27 PM
adridg added a subscriber: adridg.

LGTM, from 10.3 -- it builds, it runs, it doesn't show anything immediately silly. That is, if the means to test is "start ksysguard, then look at the *system load* tab".

This revision was automatically updated to reflect the committed changes.