Page MenuHomeFreeBSD
Differential D11434

Port PowerPC kqueue(2) compat32 fix in r320500 to MIPS.
ClosedPublic
Actions

Authored by kib on Jul 1 2017, 4:05 AM.
Tags
None
Referenced Files
F137360817: D11434.id30308.diff
Sat, Nov 22, 7:12 PM
F137360776: D11434.id.diff
Sat, Nov 22, 7:11 PM
F137360769: D11434.id30283.diff
Sat, Nov 22, 7:11 PM
F137359968: D11434.diff
Sat, Nov 22, 7:02 PM
Unknown Object (File)
Thu, Nov 20, 9:28 PM
Unknown Object (File)
Tue, Nov 18, 1:57 PM
Unknown Object (File)
Sun, Oct 26, 7:29 AM
Unknown Object (File)
Sun, Oct 26, 7:29 AM
View All 50 Files
Subscribers
imp

Details

Reviewers
brooks
jhb
Commits
rS320558: Port PowerPC kqueue(2) compat32 fix in r320500 to MIPS.
Summary

All 32bit MIPS ABIs align uint64_t on 8-byte, according to jhb. Since struct kevent32 is defined using 32bit types to avoid extra alignment on amd64/i386, layout of the structure needs paddings on PowerPC and apparently MIPS.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Jul 1 2017, 4:05 AM
Herald added a subscriber: imp. · View Herald TranscriptJul 1 2017, 4:05 AM
jhb accepted this revision.Jul 1 2017, 4:47 PM
jhb added inline comments.
sys/compat/freebsd32/freebsd32_misc.c
125 ↗(On Diff #30283)

Just checked via gdb on a recent mips o32 libc.so.7 and 'sizeof(struct kevent)' is 64.

This revision is now accepted and ready to land.Jul 1 2017, 4:47 PM
Closed by commit rS320558: Port PowerPC kqueue(2) compat32 fix in r320500 to MIPS. (authored by kib). · Explain WhyJul 1 2017, 10:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
compat/
freebsd32/
4 lines
6 lines

Diff 30308

View Options

head/sys/compat/freebsd32/freebsd32.h

Loading...
View Options

head/sys/compat/freebsd32/freebsd32_misc.c

Loading...