Page MenuHomeFreeBSD

Remove SUBDIR ordering/uniquifying in *bin/Makefile
ClosedPublic

Authored by ngie on Jun 28 2017, 7:19 PM.
Tags
None
Referenced Files
F161642277: D11398.id30187.diff
Sun, Jul 5, 12:59 PM
Unknown Object (File)
Sun, Jul 5, 4:57 AM
Unknown Object (File)
Jun 3 2026, 1:07 AM
Unknown Object (File)
May 20 2026, 4:08 AM
Unknown Object (File)
May 6 2026, 2:43 AM
Unknown Object (File)
Apr 29 2026, 11:30 AM
Unknown Object (File)
Apr 29 2026, 11:26 AM
Unknown Object (File)
Apr 28 2026, 11:30 PM
Subscribers

Details

Summary

Remove SUBDIR ordering/uniquifying in *bin/Makefile

After the addition of SUBDIR.yes, uniquifying/ordering the SUBDIRs doesn't
make a whole lot of sense, and it's in effect a half measure.

Ordering SUBDIR (after adding SUBDIR.yes to it) in bsd.subdir.mk is a
separate change that warrants more discussion/testing, because while
the SUBDIR_PARALLEL work largely fixed dependency ordering for SUBDIRs,
there might be downstream FreeBSD consumers that rely on the SUBDIR
ordering.

MFC after: 2 months

Test Plan

Need to do a build run on universe12a.freebsd.org

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Seems reasonable to me to respect the ordering of SUBDIR - and we are not ordering in the SUBDIR.yes entries so the current code is not doing much.

This revision is now accepted and ready to land.Jul 5 2017, 7:33 PM
This revision was automatically updated to reflect the committed changes.