Page MenuHomeFreeBSD

Remove SUBDIR ordering/uniquifying in *bin/Makefile
ClosedPublic

Authored by ngie on Jun 28 2017, 7:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 14, 5:10 PM
Unknown Object (File)
Fri, Aug 7, 6:04 PM
Unknown Object (File)
Fri, Aug 7, 8:23 AM
Unknown Object (File)
Thu, Aug 6, 2:00 PM
Unknown Object (File)
Thu, Aug 6, 5:52 AM
Unknown Object (File)
Jul 7 2026, 3:37 AM
Unknown Object (File)
Jul 5 2026, 12:59 PM
Unknown Object (File)
Jul 5 2026, 4:57 AM
Subscribers

Details

Summary

Remove SUBDIR ordering/uniquifying in *bin/Makefile

After the addition of SUBDIR.yes, uniquifying/ordering the SUBDIRs doesn't
make a whole lot of sense, and it's in effect a half measure.

Ordering SUBDIR (after adding SUBDIR.yes to it) in bsd.subdir.mk is a
separate change that warrants more discussion/testing, because while
the SUBDIR_PARALLEL work largely fixed dependency ordering for SUBDIRs,
there might be downstream FreeBSD consumers that rely on the SUBDIR
ordering.

MFC after: 2 months

Test Plan

Need to do a build run on universe12a.freebsd.org

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Seems reasonable to me to respect the ordering of SUBDIR - and we are not ordering in the SUBDIR.yes entries so the current code is not doing much.

This revision is now accepted and ready to land.Jul 5 2017, 7:33 PM
This revision was automatically updated to reflect the committed changes.