Details
- Reviewers
imp - Commits
- rS320321: Clean up stale dependencies after r320278
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Word-grep for <syscall>.[sS] rather than /<syscall>.[sS] since the generated asm file may appear without a full pathname.
While not technically incorrect (except maybe the lib32 comment), this papers over a weakness in the new lazy depend generation that should actually be fixed in said generation. Or failing that, the check belongs in libc generically so we don't have to maintain these silly lists.
Makefile.inc1 | ||
---|---|---|
765 | Current fast, lazy dependency generation can't cope. Old-school .depend could because this situation couldn't arise. | |
775 | I think -w isn't quite right here. I'd be tempted to use fgrep since . matches any character. It also assumes that you don't have a cross-threaded situation where normal world is fine, but lib32 isn't (because you ran once with WITHOUT_LIB32 say). But this is super gross, fragile and ugly. We should really fix the underlying problem with dependency generation rather than continually have to paper over the problem like this. I'd also think you'd want this in libc not here, since that would localize the information better. |