Page MenuHomeFreeBSD

Clean up stale dependencies after r320278
ClosedPublic

Authored by emaste on Jun 24 2017, 5:55 PM.
Tags
None
Referenced Files
F105943974: D11344.diff
Sun, Dec 22, 10:17 PM
Unknown Object (File)
Sun, Dec 15, 6:39 AM
Unknown Object (File)
Tue, Dec 10, 1:05 AM
Unknown Object (File)
Oct 19 2024, 4:53 AM
Unknown Object (File)
Oct 1 2024, 5:18 PM
Unknown Object (File)
Sep 30 2024, 1:01 AM
Unknown Object (File)
Sep 19 2024, 2:04 AM
Unknown Object (File)
Sep 18 2024, 12:58 PM
Subscribers

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Word-grep for <syscall>.[sS] rather than /<syscall>.[sS] since the generated asm file may appear without a full pathname.

While not technically incorrect (except maybe the lib32 comment), this papers over a weakness in the new lazy depend generation that should actually be fixed in said generation. Or failing that, the check belongs in libc generically so we don't have to maintain these silly lists.

Makefile.inc1
765

Current fast, lazy dependency generation can't cope. Old-school .depend could because this situation couldn't arise.

775

I think -w isn't quite right here. I'd be tempted to use fgrep since . matches any character. It also assumes that you don't have a cross-threaded situation where normal world is fine, but lib32 isn't (because you ran once with WITHOUT_LIB32 say).

But this is super gross, fragile and ugly. We should really fix the underlying problem with dependency generation rather than continually have to paper over the problem like this.

I'd also think you'd want this in libc not here, since that would localize the information better.

This revision was automatically updated to reflect the committed changes.
emaste added inline comments.
Makefile.inc1
775

I tried to do it in libc originally (the other hacks in here) but any targets in there are too late. I hope @bdrewery can take a look at a holistic approach to fixing this soon.