Page MenuHomeFreeBSD

Use PROGS instead of PROG and remove unnecessary SRCS?= assignment
ClosedPublic

Authored by ngie on Nov 7 2014, 4:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 19, 7:31 PM
Unknown Object (File)
Sun, Sep 13, 12:47 PM
Unknown Object (File)
Sat, Sep 12, 10:50 PM
Unknown Object (File)
Fri, Sep 11, 1:05 PM
Unknown Object (File)
Wed, Sep 9, 1:46 PM
Unknown Object (File)
Aug 31 2026, 8:40 AM
Unknown Object (File)
Aug 30 2026, 4:41 PM
Unknown Object (File)
Aug 29 2026, 4:23 PM
Subscribers

Details

Reviewers
asomers
Summary

Use PROGS instead of PROG and remove unnecessary SRCS?= assignment

Using PROG instead of PROGS will in cases of high -j with -DNO_ROOT cause
the PROG to show up more than once as it's handling the SCRIPTS install case
in a recursive manner, separate from the non-recursive case

After the recent batch of commits to bsd.progs.mk to fix behavior with how
variables are defaulted to, explicitly setting SRCS for a PROG is no longer
required

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ngie retitled this revision from to Use PROGS instead of PROG and remove unnecessary SRCS?= assignment.
ngie updated this object.
ngie added a reviewer: asomers.
ngie added a subscriber: jmg.
asomers edited edge metadata.

LGTM. Should ATF tests always use PROGS instead of PROG?

This revision is now accepted and ready to land.Nov 7 2014, 5:00 PM
In D1130#4, @asomers wrote:

LGTM. Should ATF tests always use PROGS instead of PROG?

Based on my empirical observations, yes. I'll add some notes to the wiki about this and communicate this out to -testing@.

Committed in r274267 -- thanks!