Page MenuHomeFreeBSD

Ent-eigen editors/calligra.
ClosedPublic

Authored by tcberner on Jun 17 2017, 8:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 16 2024, 2:31 AM
Unknown Object (File)
Dec 29 2023, 6:05 PM
Unknown Object (File)
Dec 20 2023, 6:30 AM
Unknown Object (File)
Nov 7 2023, 8:28 AM
Unknown Object (File)
Nov 5 2023, 11:01 AM
Unknown Object (File)
Oct 8 2023, 8:09 AM
Unknown Object (File)
Oct 6 2023, 7:23 AM
Unknown Object (File)
Oct 4 2023, 9:58 AM
Subscribers

Details

Reviewers
rakuco
Group Reviewers
kde
Commits
rP443736: Ent-eigen editors/calligra.
Summary

The recent update of math/eigen3 broke editors/calligra, as opencv and eigen-3.2+ contain same named parts.
Remove the using namespace Eigen from the files, and import the qualified class names instead.

This is a simplified backport of https://phabricator.kde.org/R37:2db4438671e17002c7b02e3ad3a5208930765e4f -- where they decided to qualify the classes each time (but would it would take more time to backport it -- so I prefer the sed call this time).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9943
Build 10376: arc lint + arc unit

Event Timeline

rakuco added a subscriber: rakuco.

lgtm with a nitpick (inline). Did anything else break with the Eigen update? I'm almost reverting it and asking for an exp-run.

editors/calligra/Makefile
101

Do you really need the g at the end of the expression? I'd imagine each file has a single using namespace Eigen declaration.

This revision is now accepted and ready to land.Jun 17 2017, 8:17 AM

You're right, I don't need the 'g'.

I'll build the math/eigen3 dependencies later to check for other breaks.

This revision was automatically updated to reflect the committed changes.