Page MenuHomeFreeBSD

Ent-eigen editors/calligra.
ClosedPublic

Authored by tcberner on Jun 17 2017, 8:13 AM.

Details

Reviewers
rakuco
Group Reviewers
kde
Commits
rP443736: Ent-eigen editors/calligra.
Summary

The recent update of math/eigen3 broke editors/calligra, as opencv and eigen-3.2+ contain same named parts.
Remove the using namespace Eigen from the files, and import the qualified class names instead.

This is a simplified backport of https://phabricator.kde.org/R37:2db4438671e17002c7b02e3ad3a5208930765e4f -- where they decided to qualify the classes each time (but would it would take more time to backport it -- so I prefer the sed call this time).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tcberner created this revision.Jun 17 2017, 8:13 AM
rakuco accepted this revision.Jun 17 2017, 8:17 AM
rakuco added a subscriber: rakuco.

lgtm with a nitpick (inline). Did anything else break with the Eigen update? I'm almost reverting it and asking for an exp-run.

editors/calligra/Makefile
101 ↗(On Diff #29739)

Do you really need the g at the end of the expression? I'd imagine each file has a single using namespace Eigen declaration.

This revision is now accepted and ready to land.Jun 17 2017, 8:17 AM

You're right, I don't need the 'g'.

I'll build the math/eigen3 dependencies later to check for other breaks.

This revision was automatically updated to reflect the committed changes.