Page MenuHomeFreeBSD

Allow to fetch tunable variable introduced in r319896 from getenv()
ClosedPublic

Authored by zbb on Jun 16 2017, 1:50 PM.

Details

Summary

Since CTLFLAG_NOFETCH flag doesn't allow to fetch the value from
the configuration file there is no sense for either the flag or
variable. Therefore remove NOFETCH flag.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 9934

Event Timeline

zbb created this revision.Jun 16 2017, 1:50 PM
mw_semihalf.com accepted this revision.Jun 16 2017, 4:10 PM

Tested on Armada 38x

This revision is now accepted and ready to land.Jun 16 2017, 4:10 PM
mmel edited edge metadata.Jun 17 2017, 3:52 PM

Oups, my bad, sorry.
We cannot use standard way for tunable sysctl initialization here. SYSINIT machinery is executed far after cpuinfo_init() so boot CPU doesn't get right quirks.
Anyway, I submitted fix for this in r320054.
So again, sorry for troubles...

I checked, and indeed r320054 fixes problems with obtaing the variables, so this patch is no longer needed.