Page MenuHomeFreeBSD

Safety belt on -lpthread and -lc
ClosedPublic

Authored by bapt on Nov 5 2014, 7:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 11:25 AM
Unknown Object (File)
Mon, Oct 6, 8:16 AM
Unknown Object (File)
Mon, Oct 6, 12:49 AM
Unknown Object (File)
Sun, Oct 5, 11:10 PM
Unknown Object (File)
Sep 12 2025, 1:11 AM
Unknown Object (File)
Aug 31 2025, 1:49 PM
Unknown Object (File)
Jul 29 2025, 9:08 AM
Unknown Object (File)
Jul 19 2025, 12:14 AM
Subscribers
None

Details

Reviewers
kib
imp
bdrewery
Summary

Ensure that if -lc and -lpthread are found in the LDADD chain they are always
The to last components of the link chain in the following order:
-lpthread then -lc

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bapt retitled this revision from to Safety belt on -lpthread and -lc.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: imp.
kib edited edge metadata.

I think this is fine, but please take it with a grain of salt due to my ignorance WRT both build system and make.

Also note that this is good safety belts, but not a complete solution. E.g., it does not help with the problem in r265003, since the buggy order is realized not due to the wrong appearance of -lpthread on the command line, but due to the libraries which required libthr.

This revision is now accepted and ready to land.Nov 6 2014, 8:41 AM