Page MenuHomeFreeBSD
Differential D11152

memset(3) keystr: CID 1375945
AbandonedPublic
Actions

Authored by araujo on Jun 12 2017, 7:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 24 2024, 9:37 AM
Unknown Object (File)
Jan 16 2024, 12:31 PM
Unknown Object (File)
Jan 12 2024, 6:08 PM
Unknown Object (File)
Dec 31 2023, 9:39 PM
Unknown Object (File)
Dec 3 2023, 9:23 PM
Unknown Object (File)
Nov 26 2023, 3:23 PM
Unknown Object (File)
Oct 10 2023, 2:24 PM
Unknown Object (File)
Oct 3 2023, 1:47 AM
View All 16 Files
Subscribers
imp

Details

Reviewers
cem
grehan
Summary

Zeroing keystr.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9811
Build 10246: arc lint + arc unit

Event Timeline

araujo created this revision.Jun 12 2017, 7:38 AM
Herald added a subscriber: imp. · View Herald TranscriptJun 12 2017, 7:38 AM
Harbormaster completed remote builds in B9811: Diff 29475.Jun 12 2017, 7:38 AM
cem edited edge metadata.Jun 12 2017, 3:59 PM

This one isn't needed — as Peter Grehan pointed out, strncpy() actually nul-fills the rest of the buffer if the source string was too short. I was unfamiliar with that behavior at the time :-).

araujo planned changes to this revision.Jun 13 2017, 2:05 AM

OK!

araujo abandoned this revision.Jun 13 2017, 2:05 AM

We don't need it.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
2 lines

Diff 29475

View Options

usr.sbin/bhyve/rfb.c

Loading...