Page MenuHomeFreeBSD

lib/libc/locale/xlocale_private.h compile warning fixes
Needs ReviewPublic

Authored by aprieger_llnw.com on Jun 9 2017, 4:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 12:22 AM
Unknown Object (File)
Sat, Oct 4, 9:08 AM
Unknown Object (File)
Sep 2 2025, 8:30 AM
Unknown Object (File)
Sep 2 2025, 12:42 AM
Unknown Object (File)
Aug 11 2025, 3:39 AM
Unknown Object (File)
Jul 18 2025, 12:47 PM
Unknown Object (File)
Jun 26 2025, 11:34 AM
Unknown Object (File)
Jun 24 2025, 2:38 PM
Subscribers
None

Details

Reviewers
kbowling
sbruno
Summary

warning fixes for the header file lib/libc/locale/xlocale_private.h that is compiled with a few warnings, and is used multiple times across the usr.bin/localedef application

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9756
Build 10195: arc lint + arc unit

Event Timeline

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/1abe4dd00d141096e9d6135586d4926c

  1. cddl/contrib/opensolaris/cmd/zpool/zpool_main.c
    • warning: passing 'long *' to parameter of type 'volatile u_long *' (aka 'volatile unsigned long *') converts between pointers to integer types with different sign [-Wpointer-sign]
      • fix: added the explicit modifier (volatile u_long *) to the parameter one lines 147 and 169