net-mgmt/crmsh: Update from 2.2.0 to 3.0.0
ClosedPublic
Actions

Authored by joneum on Jun 9 2017, 5:30 AM.

Details

Reviewers

tz
miwi
rene

Commits

rP443504: - net-mgmt/crmsh: Update from 2.2.0 to 3.0.0

Summary

net-mgmt/crmsh: Update from 2.2.0 to 3.0.0
Changelog: https://github.com/ClusterLabs/crmsh/blob/3.0.0/ChangeLog

PR: 219545
Submitted by: David Shane Holden (maintainer)
Approved by: xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

~/dev/ports/net-mgmt/crmsh % portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

poudriere testport:

Build with:

Build dependencies
Runtime dependencies

10amd64
10i386
11amd64
11i386
12.0-CURRENT r318899 amd64
12.0-CURRENT r318400 i386

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joneum created this revision.Jun 9 2017, 5:30 AM

Herald added a subscriber: mat. · View Herald TranscriptJun 9 2017, 5:30 AM

miwi accepted this revision.Jun 13 2017, 7:02 AM

This revision is now accepted and ready to land.Jun 13 2017, 7:02 AM

Closed by commit rP443504: - net-mgmt/crmsh: Update from 2.2.0 to 3.0.0 (authored by joneum). · Explain WhyJun 13 2017, 2:53 PM

This revision was automatically updated to reflect the committed changes.

mat added inline comments.Jun 13 2017, 3:34 PM

head/net-mgmt/crmsh/files/patch-setup.py
7–8	Unless there are occurrences of /usr/share/crmsh in that file that you do not want to be changed, I don't think there is a need to first patch the file to replace /usr/share/crmsh with %%DATADIR%% and then use sed to replace %%DATADIR%% with ${DATADIR}. Simply use sed to replace /usr/share/crmsh with ${DATADIR} in the Makefile.