blist_fill()'s return type is too narrow
ClosedPublic
Actions

Authored by alc on Jun 8 2017, 5:24 PM.

Details

Reviewers

kib
markj

Commits

rS319755: blist_fill()'s return type is too narrow. blist_fill() accepts a 64-bit

Summary

It makes no sense for blist_fill() and its helper functions to take a daddr_t "count" of blocks to fill, but return an int type value of allocated blocks. At the moment, this bug is harmless because swaponsomething() limits the size of a swap area.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

alc created this revision.Jun 8 2017, 5:24 PM

kib accepted this revision.Jun 8 2017, 5:52 PM

kib added inline comments.

kern/subr_blist.c
1049–1050	bde prefers uintmax_t and %jx for such situations.
sys/blist.h
101	externs are excessive, they could be removed once.

This revision is now accepted and ready to land.Jun 8 2017, 5:52 PM

markj accepted this revision.Jun 8 2017, 6:54 PM

Use intmax_t instead of long long.

This revision now requires review to proceed.Jun 9 2017, 2:47 AM

alc marked an inline comment as done.Jun 9 2017, 2:48 AM

alc added inline comments.Jun 9 2017, 2:50 AM

sys/blist.h
101	I interpreted your comment as suggesting a separate change for removing the externs.

kib added inline comments.Jun 9 2017, 10:12 AM

sys/blist.h
101	Exactly, this is a separate change.

Closed by commit rS319755: blist_fill()'s return type is too narrow. blist_fill() accepts a 64-bit (authored by alc). · Explain WhyJun 9 2017, 4:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

kern/

subr_blist.c

20 lines

sys/

blist.h

2 lines

Diff 29367

View Options

kern/subr_blist.c