Page MenuHomeFreeBSD

cddl/lib/libzfs build warning fixes
AbandonedPublic

Authored by aprieger_llnw.com on Jun 7 2017, 6:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 14, 2:06 AM
Unknown Object (File)
Dec 20 2023, 4:53 AM
Unknown Object (File)
Nov 18 2023, 10:17 AM
Unknown Object (File)
Nov 18 2023, 9:55 AM
Unknown Object (File)
Nov 18 2023, 8:54 AM
Unknown Object (File)
Nov 10 2023, 11:56 AM
Unknown Object (File)
Nov 8 2023, 3:20 AM
Unknown Object (File)
Oct 10 2023, 10:28 AM
Subscribers

Details

Reviewers
kbowling
sbruno
Summary

cddl/lib/libzfs build warning fixes

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9721
Build 10160: arc lint + arc unit

Event Timeline

Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/af6068106b41143d8f67525a70bbe915

  1. cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c
    • Warnings:
      • warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    • Fixes:
      • changed the print format modifier to "%"PRIu64 on lines 2401, 2967, 3024
  2. cddl/contrib/opensolaris/lib/libzfs/common/libzfs_diff.c
    • Warnings:
      • warning: format specifies type 'long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    • Fixes:
      • changed the print format modifier to "%"PRIu64 on lines 123, 417
  3. cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c
    • Warnings:
      • warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      • warning: format specifies type 'long long' but the argument has type 'long' [-Wformat]
      • warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    • Fixes:
      • changed the print format modifier to "%"PRIu64 on lines 267, 366, 2524, 2559, 3214, 3811, 3821, 3843
      • changed the print format modifier to "%ld" on lines 1462, 1523
      • changed the print format modifier to "%"PRId64 on lines 1469, 1527
  4. cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c
    • Warnings:
      • warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      • warning: incompatible pointer to integer conversion assigning to 'uint64_t' (aka 'unsigned long') from 'void *' [-Wint-conversion]
    • Fixes:
      • changed the print format modifier to "%"PRIu64 on lines 590, 596
      • added the explicit modifier to NULL on lines 820, 821, 822

This will need to be a github pull request against https://github.com/illumos/illumos-gate

Will submit changes directly to the OpenZFS Github