Page MenuHomeFreeBSD

devel/gdb: update to version 8.0
AbandonedPublic

Authored by luca.pizzamiglio_gmail.com on Jun 6 2017, 1:10 PM.

Details

Reviewers
jhb
Summary

gdb 8.0 was released. This is my effort to make it available as port

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

I'll forward port the kgdb bits into a new branch relative to 8.0 that you can use that will rename files, deal with the cleanups, etc.

gdb/files/extrapatch-kgdb
21

I would actually like to rename the kgdb files to match what upstream has done, so 'amd64-fbsd-kern.c', etc.

gdb/files/kgdb/fbsd-kld.c
154

If ldirname() is returning a std::string, then using a make_cleanup() on its c_str() method is almost certainly wrong.

285

This is now done via RAII in C++, I will need to find the replacement way to have the bfd auto-close when going out of scope.

gdb/files/patch-gdb-fbsd-nat.c
22

This should not be needed. The code is using ALL_NONEXITED_THREADS() which already skips exited threads.

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

This revision is now obsolete.
D11465 is the current one.

gdb/files/kgdb/fbsd-kld.c
285

The function make_cleanup_bfd_unref() is gone (commit 192b62ce0b4bb5c61188f570e127a26d2c32f716)

I'm not 100% sure that removing its invocation is enough.

Fixing two patching issues with new patch files and a not up-to-date Makefile (Portervision is 2)

Moreover, I've integrated the PR 219844, relaxing the Python requirement to every Python version (2 or 3)

For some reason 'arc patch xxxx' didn't work after your last change. Can you let me know which patch files you updated?

In D11074#237591, @jhb wrote:

For some reason 'arc patch xxxx' didn't work after your last change. Can you let me know which patch files you updated?

Hi John,
please, forget this upload, I added comments on the right differential.
koobs is also suggesting a way to proceed.
Sorry for the confusion.