- Add TEST option. Mpv includes a test suite executed with CMocka. - Rename LIBARCHIVE option to ARCHIVE - Cosmetic fixes
Details
Details
- Reviewers
danfe jbeich - Commits
- rP444003: multimedia/mpv: add TEST option
- portlint -ac output looks fine.
- poudriere testport builds fine on 103i386, 103amd64, 110i386, 110amd64, 120i386 and 120amd64.
- make test has passed all unittests fine.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
make test output:
===> Testing for mpv-0.25.0_1,1 [==========] Running 1 test(s). [ RUN ] test_mp_chmap_diff [ OK ] test_mp_chmap_diff [==========] 1 test(s) run. [ PASSED ] 1 test(s). [==========] Running 15 test(s). [ RUN ] test_mp_chmap_sel_fallback_upmix [ OK ] test_mp_chmap_sel_fallback_upmix [ RUN ] test_mp_chmap_sel_fallback_downmix [ OK ] test_mp_chmap_sel_fallback_downmix [ RUN ] test_mp_chmap_sel_fallback_incompatible [ OK ] test_mp_chmap_sel_fallback_incompatible [ RUN ] test_mp_chmap_sel_fallback_prefer_compatible [ OK ] test_mp_chmap_sel_fallback_prefer_compatible [ RUN ] test_mp_chmap_sel_fallback_prefer_closest_upmix [ OK ] test_mp_chmap_sel_fallback_prefer_closest_upmix [ RUN ] test_mp_chmap_sel_fallback_use_replacements [ OK ] test_mp_chmap_sel_fallback_use_replacements [ RUN ] test_mp_chmap_sel_fallback_inexact_equivalent [ OK ] test_mp_chmap_sel_fallback_inexact_equivalent [ RUN ] test_mp_chmap_sel_fallback_works_on_alsa_chmaps [ OK ] test_mp_chmap_sel_fallback_works_on_alsa_chmaps [ RUN ] test_mp_chmap_sel_fallback_mono_to_stereo [ OK ] test_mp_chmap_sel_fallback_mono_to_stereo [ RUN ] test_mp_chmap_sel_fallback_stereo_to_stereo [ OK ] test_mp_chmap_sel_fallback_stereo_to_stereo [ RUN ] test_mp_chmap_sel_fallback_no_downmix [ OK ] test_mp_chmap_sel_fallback_no_downmix [ RUN ] test_mp_chmap_sel_fallback_minimal_downmix [ OK ] test_mp_chmap_sel_fallback_minimal_downmix [ RUN ] test_mp_chmap_sel_fallback_reject_unknown [ OK ] test_mp_chmap_sel_fallback_reject_unknown [ RUN ] test_mp_chmap_sel_fallback_more_replacements [ OK ] test_mp_chmap_sel_fallback_more_replacements [ RUN ] test_mp_chmap_sel_fallback_na_channels [ OK ] test_mp_chmap_sel_fallback_na_channels [==========] 15 test(s) run. [ PASSED ] 15 test(s). [==========] Running 4 test(s). [ RUN ] test_scale_ambient_lux_limits [ OK ] test_scale_ambient_lux_limits [ RUN ] test_scale_ambient_lux_sign [ OK ] test_scale_ambient_lux_sign [ RUN ] test_scale_ambient_lux_clamping [ OK ] test_scale_ambient_lux_clamping [ RUN ] test_scale_ambient_lux_log10_midpoint [ OK ] test_scale_ambient_lux_log10_midpoint [==========] 4 test(s) run. [ PASSED ] 4 test(s).
Comment Actions
gl_video fails on 10.3 i386 or 11.0 i386 (poudriere jail) with 12.0 amd64 (host, drm-next).
[==========] Running 4 test(s). [ RUN ] test_scale_ambient_lux_limits [ ERROR ] --- fabs(x - 1.961f) <= DBL_EPSILON [ LINE ] --- ../test/gl_video.c:10: error: Failure! [ FAILED ] test_scale_ambient_lux_limits [ RUN ] test_scale_ambient_lux_sign [ ERROR ] --- fabs(x - 2.40f) <= DBL_EPSILON [ LINE ] --- ../test/gl_video.c:16: error: Failure! [ FAILED ] test_scale_ambient_lux_sign [ RUN ] test_scale_ambient_lux_clamping [ OK ] test_scale_ambient_lux_clamping [ RUN ] test_scale_ambient_lux_log10_midpoint [ ERROR ] --- fabs(x - mid_gamma) <= DBL_EPSILON [ LINE ] --- ../test/gl_video.c:30: error: Failure! [ FAILED ] test_scale_ambient_lux_log10_midpoint [==========] 4 test(s) run. [ PASSED ] 1 test(s). [ FAILED ] 3 test(s), listed below: [ FAILED ] test_scale_ambient_lux_limits [ FAILED ] test_scale_ambient_lux_sign [ FAILED ] test_scale_ambient_lux_log10_midpoint
| multimedia/mpv/Makefile | ||
|---|---|---|
| 60 ↗ | (On Diff #29174) | Maybe rename LIBARCHIVE to ARCHIVE and use _DESC from Mk/bsd.options.desc.mk. |
| 62 ↗ | (On Diff #29174) | Doesn't explain more than TEST_DESC in Mk/bsd.options.desc.mk. Maybe drop. |
| 130 ↗ | (On Diff #29174) | Use TEST_BUILD_DEPENDS = cmocka>0:sysutils/cmocka as you don't install test binaries. |
| 131 ↗ | (On Diff #29174) | What is this for? |
| 170 ↗ | (On Diff #29174) | Given TEST is a non-default option and poudriere#355 still hasn't landed maybe also add the following to always run tests if enabled. By using TEST=on for every release/arch jail you have it may help catching regressions early on updates, assuming you have time to keep the tests green. pre-install-TEST-on: do-test-TEST-on |
| 172 ↗ | (On Diff #29174) |
|
| multimedia/mpv/Makefile | ||
|---|---|---|
| 130 ↗ | (On Diff #29174) | No, it needs libcmocka.so to run unittest. Furthermore sysutils/cmocka doesn't include cmocka binary. |
| 131 ↗ | (On Diff #29174) | Mpv is unable to find libcmocka.pc in the default PKG_CONFIG_PATH. |
| 172 ↗ | (On Diff #29174) | Well, another way to run it might look like this .for test in ${TEST_UNITTESTFILES}
${WRKSRC}/build/tests/${test}
.endfor |
| multimedia/mpv/Makefile | ||
|---|---|---|
| 130 ↗ | (On Diff #29174) |
|
| 131 ↗ | (On Diff #29174) | rP442784 moved libcmocka.pc under libdata/pkgconfig. Maybe upgrade. Can you reproduce via poudriere + TEST=on? |
| multimedia/mpv/Makefile | ||
|---|---|---|
| 131 ↗ | (On Diff #29174) | You're right! Rebuilding cmocka port did the trick. |