Page MenuHomeFreeBSD

Default www/rubygem-thin to rack, not rack16
Needs ReviewPublic

Authored by adamw on May 30 2017, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 3 2024, 2:46 PM
Unknown Object (File)
Dec 29 2023, 11:55 PM
Unknown Object (File)
Sep 30 2023, 1:35 PM
Unknown Object (File)
Sep 21 2023, 5:31 PM
Unknown Object (File)
Jun 26 2023, 4:52 AM
Subscribers

Details

Reviewers
swills
Summary

www/rubygem-thin works just fine with rack 2.x as of https://github.com/macournoyer/thin/commit/f4788965226421e50b1d9bd442ea1db84444529b. So, depend on www/rubygem-rack rather than rubygem-rack16.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

The only things I see depending on thin is databases/leo_center and optionally redmine. Can you run test or at least check the Gemfiles of those to see if this causes issues? Build tests don't always catch ruby run time issues.

Makefile
18

You want to change this to >=2 so that people who have 1.6 installed are forced to update.

Both of them want rack-1.6. redmine's Gemfile says it doesn't care, but its dependencies rely upon rack-1.6. leo_center can't handle rack-2.0 at all. leo_center doesn't require rack with a version spec, so it chokes.

Sounds like just adding an OPTION to choose the backend for thin makes more sense.

Both of them want rack-1.6. redmine's Gemfile says it doesn't care, but its dependencies rely upon rack-1.6. leo_center can't handle rack-2.0 at all. leo_center doesn't require rack with a version spec, so it chokes.

Sounds like just adding an OPTION to choose the backend for thin makes more sense.

We need to have two ports for thin, one that depends on rack 1.x and another that depends on rack 2.x. Maybe "rubygem-thin" and "rubygem-thin-rack1" makes sense.

linimon retitled this revision from Default rubygem-thin to rack, not rack16 to Default www/rubygem-thin to rack, not rack16.Jul 18 2018, 12:57 PM