Page MenuHomeFreeBSD

rm stale ptrace dependencies after r305012
ClosedPublic

Authored by emaste on May 26 2017, 1:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 8, 1:55 AM
Unknown Object (File)
Tue, Apr 7, 12:46 PM
Unknown Object (File)
Sun, Apr 5, 6:12 AM
Unknown Object (File)
Sun, Apr 5, 2:41 AM
Unknown Object (File)
Fri, Mar 27, 8:41 AM
Unknown Object (File)
Fri, Mar 27, 3:36 AM
Unknown Object (File)
Wed, Mar 18, 3:34 AM
Unknown Object (File)
Sun, Mar 15, 11:15 AM
Subscribers

Details

Summary

Similar to rS318912 except that ptrace.[sS] was a file in the source tree, not a generated assembly wrapper. I'm not sure of a good way to handle this other than testing for the existence of ptrace.[sS] in the .depend file itself.

This is a bit hackish, and in any case I would not leave this indefinitely. I think one year for NO_CLEAN workarounds is more than enough time; if we persist with this approach I think we could remove the ad-hoc cleanup after say 3 months. Posting the review for discussion of the approach in general.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added a subscriber: jhb.

I'm thinking we should just have a BADFILES list, but this is fine for now.
I'd rather get this fixed for real. It's something I should put a PoC up for and discuss with Simon at BSDCan since it will be simpler with bmake changes.

This revision is now accepted and ready to land.May 26 2017, 3:23 PM
This revision was automatically updated to reflect the committed changes.