Page MenuHomeFreeBSD

usr.bin/procstat: Add missing usage and getopt(3) options
ClosedPublic

Authored by kdrakehp_zoho.com on May 25 2017, 9:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 19 2024, 7:24 AM
Unknown Object (File)
Oct 27 2024, 9:01 PM
Unknown Object (File)
Oct 4 2024, 10:48 PM
Unknown Object (File)
Sep 28 2024, 7:15 AM
Unknown Object (File)
Sep 27 2024, 11:48 PM
Unknown Object (File)
Sep 24 2024, 12:42 AM
Unknown Object (File)
Sep 22 2024, 11:39 PM
Unknown Object (File)
Sep 20 2024, 2:58 AM
Subscribers

Details

Summary
  • Add the missing option 'n' to the getopt(3) string
  • Add the missing options 'libxo' and 'N' to the usage message
  • Add the missing options 'M' and 'N' to the man-page
Test Plan

The man-page's usage section, the usage message, the getopt(3)
string, and its switch statement were checked against eachother.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9512
Build 9961: arc lint + arc unit

Event Timeline

usr.bin/procstat/procstat.c
59

At the risk of making usage longer, I think keeping [-a | pid | core ...] on it's own line is clearer.

168

'L' should come before 'l'. style(9) says the case statements should also be sorted, but I know that will create conflicts with D10916 so let's fix that after landing that change.

  • Move the last arguments of usage to a separate line
  • Correct the order of 'L' and 'l' in the getopt string

Looks good to me. I'll commit shortly.

This revision is now accepted and ready to land.May 26 2017, 7:50 PM
This revision was automatically updated to reflect the committed changes.