Page MenuHomeFreeBSD

usr.bin/procstat: Add missing usage and getopt(3) options
ClosedPublic

Authored by kdrakehp_zoho.com on May 25 2017, 9:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 15, 12:31 AM
Unknown Object (File)
Tue, Apr 7, 4:25 AM
Unknown Object (File)
Mon, Apr 6, 11:24 PM
Unknown Object (File)
Mon, Apr 6, 8:20 AM
Unknown Object (File)
Sat, Apr 4, 11:41 AM
Unknown Object (File)
Mar 24 2026, 1:05 AM
Unknown Object (File)
Mar 19 2026, 2:06 AM
Unknown Object (File)
Mar 16 2026, 12:40 PM
Subscribers

Details

Summary
  • Add the missing option 'n' to the getopt(3) string
  • Add the missing options 'libxo' and 'N' to the usage message
  • Add the missing options 'M' and 'N' to the man-page
Test Plan

The man-page's usage section, the usage message, the getopt(3)
string, and its switch statement were checked against eachother.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

usr.bin/procstat/procstat.c
57 ↗(On Diff #28820)

At the risk of making usage longer, I think keeping [-a | pid | core ...] on it's own line is clearer.

168 ↗(On Diff #28820)

'L' should come before 'l'. style(9) says the case statements should also be sorted, but I know that will create conflicts with D10916 so let's fix that after landing that change.

  • Move the last arguments of usage to a separate line
  • Correct the order of 'L' and 'l' in the getopt string

Looks good to me. I'll commit shortly.

This revision is now accepted and ready to land.May 26 2017, 7:50 PM
This revision was automatically updated to reflect the committed changes.