Page MenuHomeFreeBSD

Allow PROBE_SPINUP to fail in CAM ATA transport
ClosedPublic

Authored by avg on May 25 2017, 11:06 AM.
Tags
None
Referenced Files
F105802355: D10896.diff
Fri, Dec 20, 10:00 PM
Unknown Object (File)
Sun, Dec 1, 8:29 PM
Unknown Object (File)
Mon, Nov 25, 2:54 PM
Unknown Object (File)
Sat, Nov 23, 12:33 PM
Unknown Object (File)
Nov 18 2024, 9:45 AM
Unknown Object (File)
Oct 27 2024, 11:03 AM
Unknown Object (File)
Oct 27 2024, 3:31 AM
Unknown Object (File)
Oct 26 2024, 4:32 PM
Subscribers

Details

Summary

The motivation for this is two-fold.

  1. Some old WD SATA disks may appear as if they need to be spun up

when they are already spinning. Those disks would respond with
an error to the spin-up request.

  1. Even if we really fail to spin up the disk, we still can try to

proceed to the subsequent phases. If we fail later on, then no
difference. Otherwise we get a chance to communicate with the
disk which is better than completely ignoring it, because a user
can try to recover the disk.

Test Plan

Tested with both bad and good disks that support PUIS.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I haven't seen problems like that myself, but if you say it helps -- I have no objections.

This revision is now accepted and ready to land.May 25 2017, 5:03 PM
This revision was automatically updated to reflect the committed changes.