local.
ClosedPublic
Actions

Authored by bdrewery on May 22 2017, 5:26 PM.

Details

Reviewers

brooks

Commits

rP441483: Fix build when LOCALBASE is not /usr/local.

Test Plan

Built llvm40 with a different PREFIX + LOCALBASE. It failed
before since it was using -I/usr/local/include and -L/usr/local/lib
rather than my supplied LOCALBASE (where existing headers/libs are).

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bdrewery created this revision.May 22 2017, 5:26 PM

Herald added a subscriber: mat. · View Herald TranscriptMay 22 2017, 5:26 PM

Harbormaster completed remote builds in B9444: Diff 28683.May 22 2017, 5:26 PM

Do we need a version bump or are people with non-default PREFIX values on their own?

This revision is now accepted and ready to land.May 22 2017, 5:34 PM

In D10859#225031, @brooks wrote:

Do we need a version bump or are people with non-default PREFIX values on their own?

Since it is a build fix, no revision bump is needed. It would not build otherwise. It's also a rare thing for people to do this, but still proper to support it.

Closed by commit rP441483: Fix build when LOCALBASE is not /usr/local. (authored by bdrewery). · Explain WhyMay 22 2017, 5:39 PM

This revision was automatically updated to reflect the committed changes.