Page MenuHomeFreeBSD
Differential D10785

www/phpbb3: Add tokenizer as dependency
ClosedPublic
Actions

Authored by joneum on May 18 2017, 5:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 11 2024, 10:42 PM
Unknown Object (File)
Aug 12 2023, 9:12 PM
Unknown Object (File)
Aug 2 2023, 9:57 AM
Unknown Object (File)
Jan 13 2023, 3:04 PM
Subscribers
mat

Details

Reviewers
tz
rene
miwi
Summary

-Dump Portrevision
-Add tokenizer as dependency

PR: 219194
Reported by: Krzysztof <ports@bsdserwis.com>
Approved by: xxx (mentor)
#Differential Revision: https://review.freebsd.org/D10785

Test Plan

poudriere testport:

10amd64
10i386
11amd64
11i386
12.0-CURRENT r318899 amd64
12.0-CURRENT r318400 i386

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9351
Build 9814: arc lint + arc unit

Event Timeline

joneum created this revision.May 18 2017, 5:34 AM
Herald added a subscriber: mat. · View Herald TranscriptMay 18 2017, 5:34 AM
Harbormaster completed remote builds in B9351: Diff 28500.May 18 2017, 5:34 AM
joneum edited the summary of this revision. (Show Details)May 18 2017, 5:35 AM
joneum edited the test plan for this revision. (Show Details)
joneum edited the test plan for this revision. (Show Details)May 18 2017, 5:44 AM
tz accepted this revision.EditedMay 18 2017, 8:46 AM

Just to be picky with the commitlog:
There are missing whitespaces between '-' and the Text. Also you want to Bump the PORTREVISION. Not dump the portrevision.
Its a good habit to write variables in upper case, so a reader directly knows this is the variable and not some other context.

While working at an port its a good idea to have a look at it, if you are there. For example the CONFLICTS can be cut down. ;)

This revision is now accepted and ready to land.May 18 2017, 8:46 AM
tz closed this revision.May 18 2017, 12:22 PM

Revision Contents
Changeset List

PathSize
www/
phpbb3/
3 lines

Diff 28500

View Options

www/phpbb3/Makefile

Loading...