Fix panic in persistent hardware MAC storage
ClosedPublic
Actions

Authored by rpokala on May 11 2017, 6:06 AM.

Tags

None

Referenced Files

	F94576123: D10678.diff
	Tue, Sep 17, 6:22 PM

	F94452205: D10678.id28227.diff
	Tue, Sep 17, 9:19 AM

	Unknown Object (File)
	Sun, Sep 8, 4:26 PM

	Unknown Object (File)
	Sun, Sep 8, 1:29 PM

	Unknown Object (File)
	Sat, Sep 7, 7:34 PM

	Unknown Object (File)
	Sat, Sep 7, 12:28 PM

	Unknown Object (File)
	Fri, Sep 6, 4:08 PM

	Unknown Object (File)
	Tue, Sep 3, 8:15 AM

View All 39 Files

Subscribers

imp

Details

Reviewers

Commits

rS318176: Persistently store NIC's hardware MAC address, and add a way to retrive it

Summary

Add a forgotten NULL-check

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rpokala created this revision.May 11 2017, 6:06 AM

Herald added subscribers: ae, imp. · View Herald TranscriptMay 11 2017, 6:06 AM

I think this is correct, but I think you should skip the {}. The rest of the function does not use them for single-line if statements either.

The rest of ether_ifattach() foregoes braces for single-line blocks, so
do the same.

I've just done a quick test. The box no longer panics with this patch.

This revision is now accepted and ready to land.May 11 2017, 6:33 AM

Harbormaster completed remote builds in B9189: Diff 28226.May 11 2017, 6:41 AM

Thanks for the review, and sorry about the breakage!

Closed by commit rS318176: Persistently store NIC's hardware MAC address, and add a way to retrive it (authored by rpokala). · Explain WhyMay 11 2017, 6:46 AM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B9190: Diff 28227.May 11 2017, 7:20 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

if_ethersubr.c

3 lines

Diff 28228

View Options

head/sys/net/if_ethersubr.c

Fix panic in persistent hardware MAC storageClosedPublicActions