Fix panic in persistent hardware MAC storage
ClosedPublic
Actions

Authored by rpokala on May 11 2017, 6:06 AM.

Tags

None

Referenced Files

	F168436697: D10678.id28228.diff
	Fri, Aug 28, 8:26 AM

	Unknown Object (File)
	Sun, Aug 23, 8:06 PM

	Unknown Object (File)
	Mon, Aug 10, 8:01 PM

	Unknown Object (File)
	Sun, Aug 9, 5:06 AM

	Unknown Object (File)
	Sat, Aug 8, 11:04 PM

	Unknown Object (File)
	Sat, Aug 8, 8:58 PM

	Unknown Object (File)
	Sat, Aug 8, 9:27 AM

	Unknown Object (File)
	Sat, Aug 8, 9:26 AM

View All Files

Subscribers

imp

Details

Reviewers

Commits

rS318176: Persistently store NIC's hardware MAC address, and add a way to retrive it

Summary

Add a forgotten NULL-check

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rpokala created this revision.May 11 2017, 6:06 AM

Herald added subscribers: ae, imp. · View Herald TranscriptMay 11 2017, 6:06 AM

I think this is correct, but I think you should skip the {}. The rest of the function does not use them for single-line if statements either.

The rest of ether_ifattach() foregoes braces for single-line blocks, so
do the same.

I've just done a quick test. The box no longer panics with this patch.

This revision is now accepted and ready to land.May 11 2017, 6:33 AM

Harbormaster completed remote builds in B9189: Diff 28226.May 11 2017, 6:41 AM

Thanks for the review, and sorry about the breakage!

Closed by commit rS318176: Persistently store NIC's hardware MAC address, and add a way to retrive it (authored by rpokala). · Explain WhyMay 11 2017, 6:46 AM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B9190: Diff 28227.May 11 2017, 7:20 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

if_ethersubr.c

3 lines

Diff 28228

View Options

head/sys/net/if_ethersubr.c

Fix panic in persistent hardware MAC storageClosedPublicActions