Page MenuHomeFreeBSD

Fix panic in persistent hardware MAC storage
ClosedPublic

Authored by rpokala on May 11 2017, 6:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 1:47 AM
Unknown Object (File)
Oct 21 2023, 2:58 PM
Unknown Object (File)
Sep 7 2023, 10:03 AM
Unknown Object (File)
Sep 7 2023, 10:02 AM
Unknown Object (File)
Sep 7 2023, 9:57 AM
Unknown Object (File)
Sep 7 2023, 9:24 AM
Unknown Object (File)
Sep 1 2023, 11:16 PM
Unknown Object (File)
Sep 1 2023, 8:34 PM
Subscribers

Details

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think this is correct, but I think you should skip the {}. The rest of the function does not use them for single-line if statements either.

The rest of ether_ifattach() foregoes braces for single-line blocks, so
do the same.

I've just done a quick test. The box no longer panics with this patch.

This revision is now accepted and ready to land.May 11 2017, 6:33 AM

Thanks for the review, and sorry about the breakage!

This revision was automatically updated to reflect the committed changes.