Skip the 'status_coredump' test if coredumps are disabled via kern.coredump.
ClosedPublic
Actions

Authored by jhb on May 10 2017, 5:45 PM.

Details

Reviewers

ngie
brooks

Commits

rS318363: Skip tests depending on coredumps if coredumps are disabled via kern.coredump.

Summary

Skip the 'status_coredump' test if coredumps are disabled via kern.coredump.

The kern.coredump sysctl can be set to 0 to disable coredumps. Skip the
'status_coredump' test if this sysctl is set to 0 rather than reporting a
failure.

Submitted by: brooks
Obtained from: CheriBSD

Test Plan

Run the 'status_coredump' test with kern.coredump set to both 0 and 1. Still passes with '1', now reports 'skip' instead of FAIL for 0.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.May 10 2017, 5:45 PM

Skip wait6_coredumped as well.

LGTM -- the contrib/atf part should be pushed up to jmmv/atf, as the port contains that test as well.

This revision is now accepted and ready to land.May 10 2017, 8:46 PM

LGTM

Closed by commit rS318363: Skip tests depending on coredumps if coredumps are disabled via kern.coredump. (authored by jhb). · Explain WhyMay 16 2017, 6:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

contrib/

atf/

atf-c/

detail/

process_test.c

11 lines

netbsd-tests/

lib/

libc/

sys/

t_wait.c

12 lines

Diff 28428

View Options

head/contrib/atf/atf-c/detail/process_test.c