The 'binary' test currently in netbsd-tests/ does a basic check of the default
treatment for binary behavior, but not much further than that. Given some opportunity
for breakage recently that did not trigger any failures, add some tests to cover
the three different binary file behaviors (a, -I, -U) and their --binary-files=
equivalent values.
Details
Details
- Reviewers
emaste cem ngie - Commits
- rS318317: bsdgrep: add more tests for different binary flags
Run the tests with gnugrep and bsdgrep both to ensure proper behavior
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I did test this on the goof-up that was pointed out in D10607; it turns out that my mistake would not have broken binary file behavior anyways, because we don't bother setting f->binary at all with the -a flag, which is generally the scenario that would've ended up broken.
I'm still 50/50 on whether that's slightly terrifying or slightly warming, leaning towards 'warning' because detecting it as 'binary' is more overhead in locating a null byte.