Page MenuHomeFreeBSD

Update Tools/scripts/rmport to ignore commented out EXPIRATION_DATE lines
ClosedPublic

Authored by ler on Apr 30 2017, 4:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 5:16 PM
Unknown Object (File)
Sat, Jan 18, 10:17 PM
Unknown Object (File)
Sat, Jan 18, 10:12 PM
Unknown Object (File)
Fri, Jan 17, 3:36 PM
Unknown Object (File)
Sun, Jan 12, 6:41 AM
Unknown Object (File)
Dec 5 2024, 12:30 PM
Unknown Object (File)
Nov 28 2024, 10:01 AM
Unknown Object (File)
Nov 28 2024, 9:37 AM
Subscribers

Details

Summary

Update Tools/scripts/rmport to ignore commented out EXPIRATION_DATE lines

Test Plan

Add back the commented out Expiration date and make sure we don't get whines

Approved by: (rene|adamw) (portmgr, mentor), crees (maintainer)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove the ^ from the added grep(1) since grep -H adds the filename.
it could have spaces before it anyway.

rene requested changes to this revision.Apr 30 2017, 5:06 PM

A better alternative would be

xargs grep -H ${EXPVAR}cut -f 2 -d :grep -v ^# \

to not get distracted by comments after the expiration date

This revision now requires changes to proceed.Apr 30 2017, 5:06 PM

Or, |xargs grep -H -E "^[^#]*${EXPVAR}"

ler edited edge metadata.

Tighten up the RE for looking for commented out EXPIRATION_DATE

grep -v ^# won't catch an indented comment.

This comment was removed by adamw.
This comment was removed by ler.

Accept adamw's RE and lose one grep invocation.

ler added a reviewer: crees.
This revision is now accepted and ready to land.Apr 30 2017, 5:31 PM
This revision was automatically updated to reflect the committed changes.