Page MenuHomeFreeBSD

Prevent SEGV on corrupted msdos directories
AbandonedPublic

Authored by sevan on Apr 28 2017, 6:01 PM.
Tags
None
Referenced Files
F146750740: D10539.diff
Thu, Mar 5, 7:07 AM
Unknown Object (File)
Tue, Mar 3, 3:34 PM
Unknown Object (File)
Sun, Feb 22, 4:58 AM
Unknown Object (File)
Jan 31 2026, 11:44 AM
Unknown Object (File)
Jan 25 2026, 8:48 AM
Unknown Object (File)
Jan 24 2026, 8:05 PM
Unknown Object (File)
Jan 5 2026, 8:20 AM
Unknown Object (File)
Nov 17 2025, 1:55 PM
Subscribers

Details

Reviewers
bcr
emaste
Summary

By Veo Zhang via NetBSD
Tested it builds as an individual component (not as part of build world) but
haven't performed any tests on a file system.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8974
Build 9368: arc lint + arc unit

Event Timeline

You need to find someone more knowledgeable in that area (i.e. src-committer) to look over that change. Maybe someone who recently made some change to the same code area: https://svnweb.freebsd.org/base/head/sbin/fsck_msdosfs/

It is not incorrect but it looks somewhat weird: Perhaps it's just an off-by-one and changing k >=0 to k > 0 in line 620 solves it more cleanly.

I'll think of it for a while :).