Page MenuHomeFreeBSD

Prevent SEGV on corrupted msdos directories
AbandonedPublic

Authored by sevan on Apr 28 2017, 6:01 PM.

Details

Reviewers
bcr
emaste
Summary

By Veo Zhang via NetBSD
Tested it builds as an individual component (not as part of build world) but
haven't performed any tests on a file system.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8974
Build 9368: arc lint + arc unit

Event Timeline

sevan created this revision.Apr 28 2017, 6:01 PM
bcr edited edge metadata.Apr 29 2017, 6:59 AM

You need to find someone more knowledgeable in that area (i.e. src-committer) to look over that change. Maybe someone who recently made some change to the same code area: https://svnweb.freebsd.org/base/head/sbin/fsck_msdosfs/

pfg added a subscriber: pfg.May 26 2017, 10:41 PM

It is not incorrect but it looks somewhat weird: Perhaps it's just an off-by-one and changing k >=0 to k > 0 in line 620 solves it more cleanly.

I'll think of it for a while :).

pfg added a reviewer: emaste.Jun 15 2017, 3:41 PM
sevan abandoned this revision.Jun 7 2018, 8:30 PM

Already in.