Page MenuHomeFreeBSD

Update devel/qbs to 1.7.2
ClosedPublic

Authored by tcberner on Apr 27 2017, 6:02 AM.
Tags
None
Referenced Files
F103834474: D10521.diff
Sat, Nov 30, 1:31 AM
Unknown Object (File)
Tue, Nov 26, 6:38 PM
Unknown Object (File)
Mon, Nov 25, 8:31 PM
Unknown Object (File)
Mon, Nov 25, 2:24 AM
Unknown Object (File)
Sun, Nov 24, 5:15 AM
Unknown Object (File)
Sun, Nov 24, 4:17 AM
Unknown Object (File)
Sun, Nov 24, 2:46 AM
Unknown Object (File)
Sat, Nov 23, 9:25 PM
Subscribers

Details

Reviewers
rakuco
mat
Group Reviewers
kde
Commits
rP440020: Update devel/qbs to 1.7.2.
Summary
  • Add shebangfix, and bash as run-depends

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9025
Build 9430: arc lint + arc unit

Event Timeline

devel/qbs/Makefile
16

Does it really need bash ? Or does it just have a /bin/bash shebang and would work just fine with /bin/sh ?

The shellscript is xcode related anyway. So maybe we could just not install it as an alternative.

Sounds even better :-)

I don't think we can easily get rid of the 'bundle' module.
As it is not needed, just don't add bash as a dependency.

You could also simply remove the file in post-install :-)

It would avoid patching it, and packaging it :-)

It's part of a whole module of qbs. I'm not sure yet, how that would beave if one of its files is missing.

Rather than pulling in shebangfix, just patch the file to want /bin/sh.

The patch created a .orig file, which also wants to be installed. So just use sed, and call it a day, right? :D

But why don't you just remove it in post-install ?

Spelling police.

devel/qbs/Makefile
48

Typo here: "shut op." Would probably read better as "silence." "Shut up" usually has a negative connotation.

This revision is now accepted and ready to land.May 3 2017, 11:39 AM
This revision was automatically updated to reflect the committed changes.