Page MenuHomeFreeBSD

Add a bit about adding, moving and copying files for patches.
ClosedPublic

Authored by mat on Oct 31 2014, 2:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 24, 6:59 AM
Unknown Object (File)
Mon, Sep 22, 7:01 PM
Unknown Object (File)
Sun, Sep 21, 6:43 PM
Unknown Object (File)
Sat, Sep 20, 9:43 AM
Unknown Object (File)
Sep 16 2025, 7:17 PM
Unknown Object (File)
Aug 27 2025, 4:57 AM
Unknown Object (File)
Jul 30 2025, 3:13 AM
Unknown Object (File)
Jul 14 2025, 2:04 AM
Subscribers

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mat retitled this revision from to Add a bit about adding, moving and copying files for patches..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added reviewers: Doc Committers, portmgr.

Looks good, does it build?

I've found two things to fix.

en_US.ISO8859-1/books/porters-handbook/upgrading/chapter.xml
264 ↗(On Diff #2182)

remove the extra "have", one is enough. ;-)

271 ↗(On Diff #2182)

s/after/afterwards/

wblock added inline comments.
en_US.ISO8859-1/books/porters-handbook/upgrading/chapter.xml
94 ↗(On Diff #2186)

s/your/the/ (avoid using informal "you" and "your")

268 ↗(On Diff #2186)

"The move and copy will have to be run before" is clunky.

Better is
"<command>svn move</command> or <command>svn copy</command> must be run before the patch can be applied."

270 ↗(On Diff #2186)

Same here:

"<command>svn add</command> or <command>svn remove</command> must be run after the patch is applied."

en_US.ISO8859-1/books/porters-handbook/upgrading/chapter.xml
271 ↗(On Diff #2182)

"Afterwards" is kind of colloquial. Generally, it would be "afterward". But I think it's better to say either "after applying the patch" or "after the patch is applied."

wblock added a reviewer: wblock.

Works for me. Please build-test this massive addition before commit. Thanks!

This revision is now accepted and ready to land.Nov 7 2014, 7:53 PM
mat updated this revision to Diff 2327.

Closed by commit rD45950 (authored by @mat).