Differential D1051

Implement pselect6() system call.
ClosedPublic
Actions

Authored by dchagin on Oct 31 2014, 6:51 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 28, 11:31 AM

	Unknown Object (File)
	Thu, Nov 28, 11:31 AM

	Unknown Object (File)
	Thu, Nov 28, 11:31 AM

	Unknown Object (File)
	Thu, Nov 28, 11:31 AM

	Unknown Object (File)
	Thu, Nov 28, 11:10 AM

	Unknown Object (File)
	Tue, Nov 26, 11:29 PM

	Unknown Object (File)
	Wed, Nov 20, 10:54 AM

	Unknown Object (File)
	Wed, Nov 13, 2:48 PM

Subscribers

Details

Reviewers

Group Reviewers

Linux Emulation

Commits

rS283403: Implement pselect6() system call.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

dchagin updated this revision to Diff 2181.Oct 31 2014, 6:51 AM

dchagin retitled this revision from to Implement pselect6() system call..

dchagin added a reviewer: Linux Emulation.Oct 31 2014, 6:59 AM

trasz added a subscriber: trasz.Mar 21 2015, 4:50 PM

trasz added inline comments.

sys/amd64/linux32/syscalls.master
513	Wouldn't it be better to use l_sigset_t for sig, to match the definition in Linux?
sys/compat/linux/linux_misc.c
2094	args->sig != NULL
2096	error != 0; similar cases below
2131	Where does the "sizeof(l_int) * 8" come from?

style(9) suggestions by trasz@. abibits will be fixed in D1093.

Herald added a subscriber: imp. · View Herald TranscriptMar 24 2015, 6:13 PM

dchagin added inline comments.Mar 24 2015, 6:27 PM

sys/amd64/linux32/syscalls.master
513	*sig is a ptr to the struct l_pselect6arg defined at the start of linux_misc.c

dchagin added inline comments.Mar 24 2015, 9:28 PM

sys/compat/linux/linux_misc.c
2131	fixed by D1093!

trasz accepted this revision.Mar 25 2015, 11:16 AM

trasz added a reviewer: trasz.

This revision is now accepted and ready to land.Mar 25 2015, 11:16 AM

Closed by commit rS283403: Implement pselect6() system call. (authored by dchagin). · Explain WhyMay 24 2015, 3:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

linux32/

linux32_dummy.c

1 line

syscalls.master

5 lines

compat/

linux/

84 lines

i386/

linux/

1 line

syscalls.master

5 lines

Diff 2181

sys/amd64/linux32/linux32_dummy.c

Loading...

sys/amd64/linux32/syscalls.master

Loading...

sys/compat/linux/linux_misc.c

Loading...

sys/i386/linux/linux_dummy.c

Loading...

sys/i386/linux/syscalls.master

Loading...