Page MenuHomeFreeBSD

Add USES for meson build system (with options)
ClosedPublic

Authored by kwm on Apr 16 2017, 12:49 PM.

Details

Reviewers
swills
antoine
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

Add support for USES=meson and option ${opt}_MESON_* handling.

I added a new port graphics/graphene for testing and demonstration,
and adapted multimedia/gstreamer1 as another example. Both ports have
a few issues but I believe those are port related andnot meson itself.

Also both ports will be committed at another time.

Open problems:

  • meson complaining about using US-ASCII locale, but it really wants a Unicode compatible. I assume that commands are run in a "clean" enviroment. Because it doesn't pick up my LANG=en_US.UTF-8, not sure how to handle it.
  • Currently the --strip command is hidden behind WITH_DEBUG, is this ok?
  • graphene: introspection support is always on, ignore the comments.
  • graphene: GTKDOC option has both _ON and _TRUE for demonstration.
Test Plan

Build both graphene and gstreamer1 with meson.
Used GTKDOC _ON en _TRUE lines in graphene to test if they work.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8760
Build 9108: arc lint + arc unit

Event Timeline

Drop MESON_ENV: not used.
Add USE_LOCALE=en_US.UTF-8 to prevent meson from complaining about a

non-unicode locale. Allow users to overwrite it.

Fix graphene build in poudriere

Remove the gstreamer1 bit until that's fixed, otherwise looks fine to me. Tested locally and it works fine, I see now issues with it.

This revision is now accepted and ready to land.Apr 17 2017, 6:17 PM
antoine requested changes to this revision.Apr 17 2017, 7:08 PM
antoine added a subscriber: antoine.

The TRUE_OFF and FALSE_OFF lines look really wrong.

This revision now requires changes to proceed.Apr 17 2017, 7:08 PM

Also the documentation says that --${content} is added when -D${content}= is added

accept so it can be closed

This revision is now accepted and ready to land.Apr 17 2017, 8:38 PM

Handled antoine's comments via IRC before I noticed that the review was updated.