Page MenuHomeFreeBSD

Disable in-tree GDB by default on x86, mips, and powerpc.
ClosedPublic

Authored by jhb on Apr 14 2017, 7:21 PM.
Tags
None
Referenced Files
F86897232: D10399.diff
Thu, Jun 27, 4:58 AM
Unknown Object (File)
Tue, Jun 4, 6:22 PM
Unknown Object (File)
Apr 29 2024, 10:48 PM
Unknown Object (File)
Dec 20 2023, 2:50 AM
Unknown Object (File)
Nov 6 2023, 10:54 PM
Unknown Object (File)
Nov 4 2023, 10:47 PM
Unknown Object (File)
Nov 4 2023, 5:32 PM
Unknown Object (File)
Nov 2 2023, 1:43 AM
Subscribers

Details

Summary

Disable in-tree GDB by default on x86, mips, and powerpc.

GDB in ports contains all of the functionality as GDB in base
(including kgdb) for these platforms along with additional
functionality. In-tree GDB remains enabled on ARM and sparc64.
GDB in ports does not currently support kernel debugging on arm,
and ports GDB for sparc64 has not been tested (though it does
include sparc64 support).

Test Plan
  • Need to test this on my laptop to ensure a build DTRT and that crashinfo still runs ok on a system without GDB after a crash.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bdrewery added inline comments.
share/mk/src.opts.mk
184 ↗(On Diff #27445)

This isn't needed, and would put GDB in both YES and NO lists for !arm and !sparc64. You already are adding to the NO list below when appropriate.

This revision now requires changes to proceed.Apr 14 2017, 7:37 PM
jhb edited edge metadata.
  • Remove GDB from global NO list.
This revision is now accepted and ready to land.Apr 14 2017, 9:44 PM
jhb marked an inline comment as done.Apr 14 2017, 9:50 PM
jhb added inline comments.
share/mk/src.opts.mk
184 ↗(On Diff #27445)

Oh yes, that is a leftover from an earlier version that just turned it off everywhere.

Need to make sure we announce this fairly widely.

I think this is a good chance. I advocated doing this over a year ago now I think :)

share/mk/src.opts.mk
44 ↗(On Diff #27449)

src all the things!

This revision was automatically updated to reflect the committed changes.
jhb marked an inline comment as done.