Page MenuHomeFreeBSD
Differential D10382

Set the arm64 Execute-never bits in more places.
ClosedPublic
Actions

Authored by andrew on Apr 13 2017, 10:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 28, 12:39 AM
Unknown Object (File)
Wed, Aug 26, 4:18 AM
Unknown Object (File)
Wed, Aug 26, 2:10 AM
Unknown Object (File)
Mon, Aug 24, 11:43 AM
Unknown Object (File)
Mon, Aug 24, 11:42 AM
Unknown Object (File)
Fri, Aug 21, 2:48 PM
Unknown Object (File)
Wed, Aug 12, 12:49 PM
Unknown Object (File)
Wed, Aug 12, 12:48 PM
View All Files
Subscribers
emaste

Details

Reviewers
kib
Group Reviewers
arm64
Commits
rS316761: Set the arm64 Execute-never bits in more places.
Summary

We need to set the Execute-never bits when mapping device memory
as the hardware may perform speculative instruction fetches.

Set the Privileged Execute-ever bit on userspace memory to stop
the kernel if it is tricked into executing it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Apr 13 2017, 10:33 AM
Herald added a subscriber: emaste. · View Herald TranscriptApr 13 2017, 10:33 AM
Harbormaster completed remote builds in B8711: Diff 27401.Apr 13 2017, 10:33 AM
kib accepted this revision.Apr 13 2017, 12:45 PM
kib added inline comments.
sys/arm64/arm64/pmap.c
2731 ↗(On Diff #27401)

Why using such rude check, instead of VM_MAXUSER_ADDRESS ?

This revision is now accepted and ready to land.Apr 13 2017, 12:45 PM
andrew added inline comments.Apr 13 2017, 2:47 PM
sys/arm64/arm64/pmap.c
2731 ↗(On Diff #27401)

I'm not sure why I did that.

Closed by commit rS316761: Set the arm64 Execute-never bits in more places. (authored by andrew). · Explain WhyApr 13 2017, 3:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm64/
arm64/
21 lines

Diff 27409

View Options

head/sys/arm64/arm64/pmap.c

Loading...