Paths

Table of Contentst

Define 'lr' as x30 on aarch64
ClosedPublic
Actions

Authored by kan on Apr 7 2017, 3:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 16, 1:02 PM

	Unknown Object (File)
	Thu, Apr 16, 8:01 AM

	Unknown Object (File)
	Tue, Apr 14, 7:17 PM

	Unknown Object (File)
	Thu, Apr 9, 7:44 PM

	Unknown Object (File)
	Sat, Apr 4, 6:33 PM

	Unknown Object (File)
	Fri, Apr 3, 5:12 PM

	Unknown Object (File)
	Fri, Apr 3, 8:58 AM

	Unknown Object (File)
	Fri, Apr 3, 2:07 AM

Subscribers

Details

Reviewers

andrew
emaste
imp

Group Reviewers

arm64

Commits

rS316626: Define 'lr' as x30 on aarch64

Summary

GNU toolchain does not recognize LR as standard register alias,
but clang does. Use of #define will work on both. Place the
definition into central machine/asm.h instead of patching every
affected file, as requested by plaftorm maintainers.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kan created this revision.Apr 7 2017, 3:36 PM

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptApr 7 2017, 3:36 PM

kan added reviewers: andrew, emaste, arm64.Apr 7 2017, 3:36 PM

lgtm

This revision is now accepted and ready to land.Apr 7 2017, 3:38 PM

Harbormaster failed remote builds in B8584: Diff 27182!Apr 7 2017, 3:40 PM

andrew accepted this revision.Apr 7 2017, 3:45 PM

No objection from me. I am a bit puzzled by us having a mix of lr and x30 in our .S sources though.

Closed by commit rS316626: Define 'lr' as x30 on aarch64 (authored by kan). · Explain WhyApr 7 2017, 10:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

include/

asm.h

3 lines

Diff 27207

View Options

head/sys/arm64/include/asm.h

Define 'lr' as x30 on aarch64ClosedPublicActions