make e6060sw, adm6996fc, ksz8995ma man page
Details
Details
- Reviewers
mizhka adrian - Group Reviewers
manpages - Commits
- rS317867: [etherswitch] add manpages for etherswitch supported devices.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thank you for writing these man pages. I added some corrections. It seems like a lot, but they can be easily fixed.
You should install textproc/igor and run it over thes man pages. It will show you where the errors are and suggests fixes. When there are no more errors reported, you can create a new patch and update this review.
Thanks again.
| share/man/man4/adm6996fc.4 | ||
|---|---|---|
| 43 ↗ | (On Diff #27073) | You need to have a hard line break after the sentence stop (after chip). |
| 45 ↗ | (On Diff #27073) | This driver supports port and dot1q vlan. Also, line break after the sentence stop. |
| 47 ↗ | (On Diff #27073) | Configure dot1q vlan with the etherswitchcfg command. |
| 51 ↗ | (On Diff #27073) | Configure port 5 as the tagging port. |
| share/man/man4/e6060sw.4 | ||
| 43 ↗ | (On Diff #27073) | Another line break here after the sentence stop. |
| 45 ↗ | (On Diff #27073) | 88E6060 supports only the vlan port. Line break after that sentence. |
| 47 ↗ | (On Diff #27073) | Configure dot1q vlan on 88E6065 with the etherswitchcfg command. |
| 51 ↗ | (On Diff #27073) | Yet another line break between the two sentences. |
| share/man/man4/ksz8995ma.4 | ||
| 43 ↗ | (On Diff #27073) | Line break between the sentences. The second sentence should be: |
| 45 ↗ | (On Diff #27073) | This driver supports port and dot1q vlan. Line break. |
| 47 ↗ | (On Diff #27073) | Same as in the other man pages. |
| 51 ↗ | (On Diff #27073) | is => as the |
| share/man/man4/adm6996fc.4 | ||
|---|---|---|
| 43 ↗ | (On Diff #27121) | to /the/ Infineon |
| 44 ↗ | (On Diff #27121) | Can you explain further? Is the case here that adm6996fc is connected by SMI to some (other) Ethernet interface in the system, and configured over SMI? Also, should expand acronym on first use, e.g. the Serial Management Interface (SMI) |
Comment Actions
Mavell e6060 datasheet use SMI word. That is MDC/MDIO. But Infineon data sheet not use SMI work. Do I change "MDC/MDIO interface" from "SMI". I want say difference i2c or spi bus.
Comment Actions
hi,
This is .. doing git like things to try and find /copies/ from th eoriginal source files, so the diff as downloaded doesn't work :(