Page MenuHomeFreeBSD

bsdgrep(1): Rip out xmalloc bits
ClosedPublic

Authored by kevans on Apr 4 2017, 4:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 5:58 PM
Unknown Object (File)
Tue, Nov 12, 8:10 PM
Unknown Object (File)
Sun, Nov 10, 4:41 AM
Unknown Object (File)
Sun, Oct 27, 2:51 PM
Unknown Object (File)
Sun, Oct 27, 2:34 PM
Unknown Object (File)
Oct 3 2024, 1:46 AM
Unknown Object (File)
Sep 16 2024, 12:19 PM
Unknown Object (File)
Sep 16 2024, 12:19 PM
Subscribers
None

Details

Summary

xmalloc was a debug malloc implementation, but the x{malloc,calloc,free} functions default to calling the jemalloc(3) equivalents.

Instead of relying on this malloc shim, I think we can devise better ways to debug malloc issues that aren't misleading upon initial inspection. I've gone ahead and replaced all of the calls with their jemalloc(3) equivalents so that it's obvious that they follow its behavior.

Test Plan

Ensure no kyua test regressions following this change

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Worth noting: when this lands, D10098 will (probably?) need re-adjusted, since it switches an xmalloc to xcalloc.

This revision is now accepted and ready to land.Apr 4 2017, 5:23 AM
This revision was automatically updated to reflect the committed changes.