Page MenuHomeFreeBSD

Update graphics/showimage to 0.10 and take maintainership
ClosedPublic

Authored by tcberner on Mar 29 2017, 10:25 PM.

Details

Summary
  • Update to 0.10 (kf5)
  • Rename the installed binary from showimage to showimage-kde (previously it was showimage-kde4, but that does not make much sense anymore)
  • Take maintainership.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tcberner created this revision.Mar 29 2017, 10:25 PM
mat added inline comments.Mar 30 2017, 6:52 AM
graphics/showimage/files/patch-showimage.desktop
1 ↗(On Diff #26795)

I don't see the point in this comment.
I get the idea, but this has the same problem as the trend of writing very bad commit messages explaining almost line by line what is being done in the commit.
The what is self-explanatory, yeah, the executable is renamed, I can see that.
A better comment would be "don't conflict with blah", and stop there, or, as it was already explained in another patch, just "see patch-foo".

tcberner updated this revision to Diff 26808.Mar 30 2017, 6:55 AM

Get rid of obvious comment.

mat added inline comments.Mar 30 2017, 7:23 AM
graphics/showimage/Makefile
23 ↗(On Diff #26808)

I don't really see the point in setting the id outside of the URL, it is not used anywhere else.

I also grep'ed the ports tree, and there does not seem to be any other use of that variable.

tcberner updated this revision to Diff 26809.Mar 30 2017, 7:35 AM

Get rid of ID-variable.

mat accepted this revision.Mar 30 2017, 9:50 PM

Looks good :-)

This revision is now accepted and ready to land.Mar 30 2017, 9:50 PM
This revision was automatically updated to reflect the committed changes.