Page MenuHomeFreeBSD

Update math/labplot to 2.3.0 and give maintainership to kde@ (now hosted on kde.org).
ClosedPublic

Authored by tcberner on Mar 29 2017, 10:08 AM.

Details

Summary
  • Update to 2.3.0
  • Switch to kf5 based version.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

The patch comments got lost.

math/labplot/pkg-plist
146 ↗(On Diff #26759)

@mat should I

  • override DATADIR for the port and drop the 2 or
  • replace %%DATADIR%% by share/labplot
math/labplot/pkg-plist
146 ↗(On Diff #26759)

I think you can just do DATADIR= ${PREFIX}/share/labplot2 in the Makefile.

Update, with DATADIR=...2.

math/labplot/Makefile
6 ↗(On Diff #26944)

Is this really necessary? To me this is just an update to the port that happens to make it depend on Qt5/KF5.

13 ↗(On Diff #26944)

The license (at least in the handful of files I checked) seems to be GPLv2+.

16 ↗(On Diff #26944)

v2.3.0 seems to always look for some optional dependencies and enable them if they happen to be found (there's been a commit in git after that which adds CMake options for those dependencies). fftw3, hdf5, netcdf and cantor all seem to fall in this category.

You need to either depend on them unconditionally (not sure if any of those is too big a dependency) or make sure they are not automagically enabled if found.

26 ↗(On Diff #26944)

I wonder if these two are still necessary.

tcberner marked 3 inline comments as done.

Backport commit to make hdf5, fftw3 and netcdf optional.
Adress other issues mentioned by rakuco.

math/labplot/Makefile
6 ↗(On Diff #26944)

This is DISTVERSIONPREFIX, it has no influenc on the pkgname (they provide two tarballs, one is called labplot-2.3.0-kf5.tar.xz, the other labplot-2.3.0.tar.xz).

16 ↗(On Diff #26944)

I'll try to optionify it. Cantor won't be picked up anyway, as it is still the outdated version.

26 ↗(On Diff #26944)

You're right. According to stage-qa they are not needed.

tcberner retitled this revision from Update math/labplot to 2.3.0 and take maintainership for kde@ (now hosted on kde.org). to Update math/labplot to 2.3.0 and give maintainership to kde@ (now hosted on kde.org)..Apr 4 2017, 1:27 PM
This revision is now accepted and ready to land.Apr 4 2017, 2:26 PM
This revision was automatically updated to reflect the committed changes.