Fix x11-themes/kde4-windeco-crystal's, deskutils/plasma-applet-daisy and deskutils/plasma-applet-yawp build with newer kdelibs

[tcberner]

Summary

1. Cmake policy CMP0005 automatically escapes add_defintions arguments
2. Use the variables from the kde4 cmake files to link against the libraries.

[rakuco]

[jhale]

deskutils/plasma-applet-daisy won't actually link to the taskmanager library because find_package(KDE4Workspace REQUIRED) is needed to define ${KDE4WORKSPACE_TASKMANAGER_LIBRARY}. It will build and link, but will cause a crash of plasma-desktop on startup. I already have fixes for deskutils/plasma-applet-daisy and deskutils/plasma-applet-yawp that add some missing dependencies and license updates as well, so please leave those to me.

[tcberner]

Get rid of the incomplete fixes to deskutils/plasma-* as requested by jhale@.

[jhale]

deskutils/plasma-applet-daisy fixed in https://reviews.freebsd.org/rP437186
deskutils/plasma-applet-yawp fixed in https://reviews.freebsd.org/rP437187

[jhale]

x11-themes/kde4-windeco-crystal/files/patch-CMakeLists.txt

11 ↗

(On Diff #26754)

I'm seeing a build failure because of this change:

• client/CMakeFiles/kwin3_crystal.dir/crystalclient.o ---

/usr/home/Jason/src/freebsd/ports/x11-themes/kde4-windeco-crystal/work/crystal-2.2.1/client/crystalclient.cpp:121:71: error: invalid suffix '.1' on floating constant

sprintf(c,"<center><b>Crystal %s Preview</b><br>Built: %s</center>",VERSION, __DATE__);
                                                                    ^

<command line>:11:20: note: expanded from here
#define VERSION 2.2.1

^

1 error generated.

x11-themes/kde4-windeco-crystal/files/patch-client_CMakeLists.txt

10 ↗

(On Diff #26754)

You need to add find_package(KDE4Workspace REQUIRED) somewhere for ${KDE4WORKSPACE_KDECORATIONS_LIBS} to be defined. It isn't linking to it otherwise.

[tcberner]

x11-themes/kde4-windeco-crystal/files/patch-CMakeLists.txt

11 ↗

(On Diff #26754)

Hm, this worked for me. Is your x11/kdelibs up to date? -- Maybe I should forcefully set CMP0005 to NEW additionally, or set it to OLD and do nothing.

[jhale]

x11-themes/kde4-windeco-crystal/files/patch-CMakeLists.txt

11 ↗

(On Diff #26754)

I'm still using the previous x11/kdelibs4, however setting cmake_minimum_required(VERSION 2.8.9) fixes the problem.

[tcberner]

Additionally set CMP0005 to NEW, and include find_package call for KDE4-Worspace.

[rakuco]

Still lgtm.

x11-themes/kde4-windeco-crystal/files/patch-CMakeLists.txt

23 ↗

(On Diff #26757)

I'm OK with this, but another way to solve this is escaping it the way kde-gtk-config does in its patch in files/.

[tcberner]

x11-themes/kde4-windeco-crystal/files/patch-CMakeLists.txt

23 ↗

(On Diff #26757)

I trust cmake more to properly escape it, than myself :D

[tcberner]

@jhale are you ok with this like it is now?

[jhale]

Ship it!