Page MenuHomeFreeBSD

Patch icu to use UTF-8 instead of ASCII outside C locale and ensure UTF-8 is default
ClosedPublic

Authored by rezny on Mar 24 2017, 10:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 27, 5:43 PM
Unknown Object (File)
Sun, Sep 21, 12:18 PM
Unknown Object (File)
Fri, Sep 19, 6:18 AM
Unknown Object (File)
Sep 3 2025, 8:31 AM
Unknown Object (File)
Aug 31 2025, 2:37 PM
Unknown Object (File)
Jul 26 2025, 3:58 AM
Unknown Object (File)
Jul 25 2025, 3:19 AM
Unknown Object (File)
Jun 30 2025, 9:43 PM
Subscribers

Details

Summary

From PR 216372: Some QT5 (e.g. qTox) apps have trouble with non-ASCII filenames. Root cause: ucnv_getDefaultName() is called before setlocale() so it returns ASCII. The solution is to handle BSD the same as is done for Darwin and Linux; map ASCII to UTF-8 outside POSIX 'C' locale. The implementation uses the Darwin code path because it already matched in other respects (CP949 is remapped but nothing else, whereas Linux has special handling for more Asian locales). The PR has gone 2 months without action from office@

Test Plan

Poudriere 10.3/11.0 amd64/i386 OK, verified qTox now correctly handles files with Unicode names

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt added a subscriber: bapt.

please consider upstreaming that as well

This revision is now accepted and ready to land.Mar 24 2017, 12:38 PM
This revision was automatically updated to reflect the committed changes.