Page MenuHomeFreeBSD
Differential D10110

fix detection of zlib sources, fix on -CURRENT
ClosedPublic
Actions

Authored by ler on Mar 23 2017, 12:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 2:08 PM
Unknown Object (File)
Fri, Nov 22, 2:08 PM
Unknown Object (File)
Fri, Nov 22, 2:08 PM
Unknown Object (File)
Fri, Nov 22, 2:08 PM
Unknown Object (File)
Fri, Nov 22, 2:03 PM
Unknown Object (File)
Thu, Nov 21, 5:12 PM
Unknown Object (File)
Wed, Nov 20, 4:07 AM
Unknown Object (File)
Oct 19 2024, 10:07 AM
View All 76 Files
Subscribers
mat

Details

Reviewers
adamw
rene
Commits
rP436749: fix finding of the zlib sources.
Summary

fix finding of the zlib sources.

PR: 216212
Submitted By: amdmi3
Approved by: fernando.apesteguia@gmail.com, phk, adamw (mentor)

Test Plan

poudriere (12, 11)
http://home.lerctr.org:8888/build.html?mastername=p110amd64-ler-checkout&build=2017-03-22_19h35m56s
http://home.lerctr.org:8888/build.html?mastername=live-ler-checkout&build=2017-03-22_19h31m04s

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ler created this revision.Mar 23 2017, 12:42 AM
Herald added a subscriber: mat. · View Herald TranscriptMar 23 2017, 12:42 AM
Harbormaster completed remote builds in B8235: Diff 26577.Mar 23 2017, 12:42 AM
adamw edited edge metadata.Mar 23 2017, 12:44 AM

Did you mean to delete virtualbox patches in this review?

ler edited the summary of this revision. (Show Details)Mar 23 2017, 12:45 AM
ler added a comment.Mar 23 2017, 1:07 AM

No. I could re-check out my tree, and the commit would be in the opennurbs directory.

ler updated this revision to Diff 26580.Mar 23 2017, 1:12 AM

fix errouneous VirtualBox patch deletes

Harbormaster completed remote builds in B8238: Diff 26580.Mar 23 2017, 1:12 AM
adamw accepted this revision.Mar 23 2017, 1:16 AM

Other than that trailing slash, this looks good.

For your commit message, put @phk as a reviewer, not approver.

graphics/opennurbs/Makefile
45 ↗(On Diff #26580)

For consistency, please remove the trailing slash. None of the other commands have it.

This revision is now accepted and ready to land.Mar 23 2017, 1:16 AM
Closed by commit rP436749: fix finding of the zlib sources. (authored by ler). · Explain WhyMar 23 2017, 1:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
graphics/
opennurbs/
60 lines
files/
2 lines
29 lines

Diff 26581

View Options

head/graphics/opennurbs/Makefile

Loading...
View Options

head/graphics/opennurbs/files/patch-opennurbs__system.h

Loading...
View Options

head/graphics/opennurbs/pkg-plist

Loading...