bsdgrep(1): Understand rgrep, create rgrep symlink if using bsdgrep
ClosedPublic
Actions

Authored by kevans on Mar 22 2017, 11:10 PM.

Details

Reviewers

emaste
cem

Commits

rS316484: bsdgrep(1): create rgrep link

Summary

Create a convenience rgrep symlink for bsdgrep(1) that observes grep -r behavior

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8476
Build 8777: arc lint + arc unit

Event Timeline

kevans created this revision.Mar 22 2017, 11:10 PM

Interesting, the gnugrep package does not install rgrep, but this change seems sensible regardless of whether we install rgrep or not.

This revision is now accepted and ready to land.Mar 22 2017, 11:32 PM

I committed the grep.c part of the change in rS316473. I'm less sure about installing the symlink, but in any case if we add it it should be mentioned in the man page and have a MLINKS entry.

This revision now requires review to proceed.Apr 3 2017, 9:12 PM

Amend manpage to mention rgrep, add MLINK for it

Harbormaster completed remote builds in B8476: Diff 26993.Apr 3 2017, 9:44 PM

I went ahead and updated this, since I don't think it necessarily hurts to go ahead and install rgrep due to:

It is only WITH_BSD_GREP (at the moment), so I'm not sure that it hurts much
-r is a really commonly used flag
rgrep is also really commonly installed on many GNU/Linux distributions, which isn't a good argument in itself but it would allow for a friendly migration for many

cem accepted this revision.Apr 4 2017, 5:48 AM

This revision is now accepted and ready to land.Apr 4 2017, 5:48 AM

Closed by commit rS316484: bsdgrep(1): create rgrep link (authored by cem). · Explain WhyApr 4 2017, 5:57 AM

This revision was automatically updated to reflect the committed changes.