pf: Fix memory leak on vnet shutdown or unload
ClosedPublic
Actions

Authored by kp on Mar 17 2017, 5:37 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 7, 5:43 PM

	Unknown Object (File)
	Sun, Sep 6, 9:46 PM

	Unknown Object (File)
	Sat, Sep 5, 3:25 PM

	Unknown Object (File)
	Sat, Sep 5, 11:22 AM

	Unknown Object (File)
	Sat, Sep 5, 3:18 AM

	Unknown Object (File)
	Sat, Sep 5, 12:55 AM

	Unknown Object (File)
	Fri, Sep 4, 11:09 PM

	Unknown Object (File)
	Fri, Sep 4, 9:15 PM

View All Files

Subscribers

Details

Reviewers

eri
bz

Group Reviewers

network

Commits

rS315469: pf: Fix memory leak on vnet shutdown or unload

Summary

Rules are unlinked in shutdown_pf(), so we must call
pf_unload_vnet_purge(), which frees unlinked rules, after that, not
before.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Mar 17 2017, 5:37 AM

kp added reviewers: network, eri.Mar 17 2017, 5:54 AM

kp set the repository for this revision to rS FreeBSD src repository - subversion.

Good catch.

This revision is now accepted and ready to land.Mar 17 2017, 10:02 PM

It is unclear to me why I had chosen the different order in r302156 but on a quick glance this looks OK.

Closed by commit rS315469: pf: Fix memory leak on vnet shutdown or unload (authored by kp). · Explain WhyMar 18 2017, 1:37 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netpfil/

pf/

pf_ioctl.c

4 lines

Diff 26379

View Options

head/sys/netpfil/pf/pf_ioctl.c

pf: Fix memory leak on vnet shutdown or unloadClosedPublicActions