Page MenuHomeFreeBSD
Differential D10019

vmoff()'s return type is too narrow
ClosedPublic
Actions

Authored by alc on Mar 15 2017, 9:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 1, 2:41 PM
Unknown Object (File)
Dec 6 2024, 7:38 PM
Unknown Object (File)
Oct 23 2024, 4:23 AM
Unknown Object (File)
Oct 23 2024, 4:23 AM
Unknown Object (File)
Oct 23 2024, 4:23 AM
Unknown Object (File)
Oct 23 2024, 4:01 AM
Unknown Object (File)
Oct 4 2024, 3:04 PM
Unknown Object (File)
Oct 1 2024, 7:07 AM
View All 47 Files
Subscribers
None

Details

Reviewers
glebius
kib
Commits
rS319540: The data type returned by vmoff() is too narrow in its range. This could
Summary

While reviewing all of the use cases of OFF_TO_IDX(), I observed that vmoff()'s return type is vm_offset_t rather than vm_ooffset_t. Consequently, sendfile() could have problems transmitting files larger than 4 GB on 32-bit architectures.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

alc created this revision.Mar 15 2017, 9:35 PM
kib accepted this revision.Mar 15 2017, 9:40 PM
This revision is now accepted and ready to land.Mar 15 2017, 9:40 PM
Closed by commit rS319540: The data type returned by vmoff() is too narrow in its range. This could (authored by alc). · Explain WhyJun 3 2017, 4:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
kern/
4 lines

Diff 26291

View Options

kern/kern_sendfile.c

Loading...