Page MenuHomeFreeBSD

vmoff()'s return type is too narrow
ClosedPublic

Authored by alc on Mar 15 2017, 9:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 4, 2:41 AM
Unknown Object (File)
Fri, Oct 3, 10:25 AM
Unknown Object (File)
Thu, Oct 2, 4:50 PM
Unknown Object (File)
Thu, Oct 2, 4:42 PM
Unknown Object (File)
Sep 21 2025, 5:08 PM
Unknown Object (File)
Aug 18 2025, 3:13 PM
Unknown Object (File)
Aug 12 2025, 2:59 PM
Unknown Object (File)
Aug 11 2025, 2:02 AM
Subscribers
None

Details

Summary

While reviewing all of the use cases of OFF_TO_IDX(), I observed that vmoff()'s return type is vm_offset_t rather than vm_ooffset_t. Consequently, sendfile() could have problems transmitting files larger than 4 GB on 32-bit architectures.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 15 2017, 9:40 PM
This revision was automatically updated to reflect the committed changes.