vmoff()'s return type is too narrow
ClosedPublic
Actions

Authored by alc on Mar 15 2017, 9:35 PM.

Tags

None

Referenced Files

	F175814491: D10019.id26291.diff
	Tue, Oct 13, 2:30 PM

	F175814486: D10019.id29176.diff
	Tue, Oct 13, 2:30 PM

	F175813310: D10019.diff
	Tue, Oct 13, 2:18 PM

	Unknown Object (File)
	Tue, Oct 13, 3:16 AM

	Unknown Object (File)
	Mon, Oct 12, 11:30 PM

	Unknown Object (File)
	Mon, Oct 12, 8:42 AM

	Unknown Object (File)
	Mon, Oct 12, 6:13 AM

	Unknown Object (File)
	Sun, Oct 11, 1:51 PM

View All Files

Subscribers

None

Details

Reviewers

glebius
kib

Commits

rS319540: The data type returned by vmoff() is too narrow in its range. This could

Summary

While reviewing all of the use cases of OFF_TO_IDX(), I observed that vmoff()'s return type is vm_offset_t rather than vm_ooffset_t. Consequently, sendfile() could have problems transmitting files larger than 4 GB on 32-bit architectures.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alc created this revision.Mar 15 2017, 9:35 PM

kib accepted this revision.Mar 15 2017, 9:40 PM

This revision is now accepted and ready to land.Mar 15 2017, 9:40 PM

Closed by commit rS319540: The data type returned by vmoff() is too narrow in its range. This could (authored by alc). · Explain WhyJun 3 2017, 4:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

kern_sendfile.c

4 lines

Diff 29176

View Options

head/sys/kern/kern_sendfile.c

vmoff()'s return type is too narrowClosedPublicActions