Page MenuHomeFreeBSD
Differential D10019

vmoff()'s return type is too narrow
ClosedPublic
Actions

Authored by alc on Mar 15 2017, 9:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 10, 4:51 AM
Unknown Object (File)
Wed, Sep 9, 2:06 PM
Unknown Object (File)
Sun, Sep 6, 4:07 PM
Unknown Object (File)
Sun, Sep 6, 3:58 PM
Unknown Object (File)
Sun, Aug 23, 5:49 AM
Unknown Object (File)
Jun 2 2026, 1:03 PM
Unknown Object (File)
May 28 2026, 1:00 PM
Unknown Object (File)
May 28 2026, 12:16 PM
View All Files
Subscribers
None

Details

Reviewers
glebius
kib
Commits
rS319540: The data type returned by vmoff() is too narrow in its range. This could
Summary

While reviewing all of the use cases of OFF_TO_IDX(), I observed that vmoff()'s return type is vm_offset_t rather than vm_ooffset_t. Consequently, sendfile() could have problems transmitting files larger than 4 GB on 32-bit architectures.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alc created this revision.Mar 15 2017, 9:35 PM
kib accepted this revision.Mar 15 2017, 9:40 PM
This revision is now accepted and ready to land.Mar 15 2017, 9:40 PM
Closed by commit rS319540: The data type returned by vmoff() is too narrow in its range. This could (authored by alc). · Explain WhyJun 3 2017, 4:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
4 lines

Diff 29176

View Options

head/sys/kern/kern_sendfile.c

Loading...