Page MenuHomeFreeBSD

Do not claim libbearssl et al are INTERNALLIB
Needs ReviewPublic

Authored by sjg on Mar 31 2020, 1:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 2, 6:41 PM
Unknown Object (File)
Nov 19 2024, 10:48 AM
Unknown Object (File)
Nov 19 2024, 10:47 AM
Unknown Object (File)
Sep 20 2024, 1:16 PM
Unknown Object (File)
Sep 17 2024, 12:48 PM
Unknown Object (File)
Sep 8 2024, 7:35 PM
Unknown Object (File)
Sep 4 2024, 8:44 PM
Unknown Object (File)
Sep 4 2024, 1:59 PM

Details

Reviewers
emaste
Summary

If INTERNALLIB is defined we need PIE and bsd.incs.mk is
not included.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30200
Build 27988: arc lint + arc unit

Event Timeline

lib/libbearssl/Makefile.depend
5

unrelated to this change, you can commit it separately

lib/libveriexec/Makefile
3

OK

share/mk/src.libnames.mk
229โ€“230

I think these should probably still have ${PIE_SUFFIX}, and the MK_PIE test at line 419 should be extended to include a check for NO_SHARED too, but there will be no practical impact and I think this is fine for now.

sjg added inline comments.
share/mk/src.libnames.mk
229โ€“230

None of these libs define NO_SHARED, so they do not produce _pie.