HomeFreeBSD

MFC r366771:

Description

MFC r366771:

bhyve: Update TX descriptor base address and host mapping on change

bhyve sometimes segfaults when using an e1000 NIC with a Windows guest.

We are only updating our tdba and cached host mapping when the low address
register is written and when tx is set enabled, but not when the high address
or length registers are written. It is observed that Windows 10 is occasionally
enabling tx first then writing the registers in the order low, high, len. This
leaves us with a bogus base address and mapping, which causes a segfault later
when we try to copy from a descriptor that has unpredictable garbage in a
pointer.

Updating the address and mapping when any of those registers change seems to fix
that particular issue.

Reviewed by: mav, grehan (bhyve)
Sponsored by: iXsystems, Inc.
Differential Revision: https://reviews.freebsd.org/D26798

Details

Provenance
freqlabsAuthored on
Reviewer
mav
Differential Revision
D26798: /usr/sbin/bhyve: Update TX descriptor base address and host mapping on change
Parents
rS366964: MFC r366768:
Branches
Unknown
Tags
Unknown