HomeFreeBSD

Re-enable receive flow control for TOE TLS sockets.

Description

Re-enable receive flow control for TOE TLS sockets.

Flow control was disabled during initial TOE TLS development to
workaround a hang (and to match the Linux TOE TLS support for T6).
The rest of the TOE TLS code maintained credits as if flow control was
enabled which was inherited from before the workaround was added with
the exception that the receive window was allowed to go negative.
This negative receive window handling (rcv_over) was because I hadn't
realized the full implications of disabling flow control.

To clean this up, re-enable flow control on TOE TLS sockets. The
existing TPF_FORCE_CREDITS workaround is sufficient for the original
hang. Now that flow control is enabled, remove the rcv_over
workaround and instead assert that the receive window never goes
negative matching plain TCP TOE sockets.

Reviewed by: np
MFC after: 2 weeks
Sponsored by: Chelsio Communications
Differential Revision: https://reviews.freebsd.org/D26799

Details

Provenance
jhbAuthored on
Reviewer
np
Differential Revision
D26799: Re-enable receive flow control for TOE TLS sockets.
Parents
rS366853: cxgbe(4): Fix page fault in t4_get_lb_stats with 2 port T5 cards.
Branches
Unknown
Tags
Unknown