HomeFreeBSD

Eliminate xpt_copy_path.

Description

Eliminate xpt_copy_path.

It's used in exactly one place. In that place it's used so we can hold the lock
on the device associated with the path (since we do a xpt_path_lock and unlock
pair around the callback). Instead, inline taking and dropping the reference to
the device so we can ensure we can unlock the mutex after the callback finishes
if the path in the ccb that's queued to be processed by xpt_scanner_thread is
destroyed while being processed. We don't actually need the path itself for
anything other than dereferencing it to get the device to do the lock and
unlock.

This also makes the locking / use model for cam_path a little cleaner by
eliminating a case where we needlessly copy the object.

Reviewed by: chuck, chs, ken
Differential Revision: https://reviews.freebsd.org/D24008

Details

Provenance
impAuthored on
Reviewer
chuck
Differential Revision
D24008: Various cleanups: remove unused / under-used stuff.
Parents
rS358863: Remove unused cam ccb flags
Branches
Unknown
Tags
Unknown